Skip to content

feat: add beneficiary_detail in scheme.prisma#105

Open
dhruv-1001 wants to merge 1 commit intodevfrom
beneficiary-detail-schema
Open

feat: add beneficiary_detail in scheme.prisma#105
dhruv-1001 wants to merge 1 commit intodevfrom
beneficiary-detail-schema

Conversation

@dhruv-1001
Copy link
Copy Markdown
Collaborator

No description provided.

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
workflow-wrapper ❌ Failed (Inspect) Dec 4, 2023 7:00am
workflow-wrapper-1 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2023 7:00am
workflow-wrapper-zzbk ❌ Failed (Inspect) Dec 4, 2023 7:00am

@singhalkarun
Copy link
Copy Markdown

@dhruv-1001

Let's make this improvements in schema. Since, we don't have any relation of this table with other tables, we will directly migrate the data from old DB to new DB after making the transformations. This can be a low priority thing for now as there's no post processing that has to happen immediately.

  1. camelCase table names make the queries syntactically harder when DB is directly queried through tools like Metabase. To be rethought if it's a good option.
  2. Use DB Level Constraints. (e.g., if aadharVaultReference has a fixed length we can set it as constraint on DB as well). VARCHAR is preferred over text in this case. It is storage efficient
  3. Should use the type specific field, like for DOB, it's good to use a date field as it makes querying easier as we get access to built in functions
  4. Try to use ENUMs for field with fixed smaller number of values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants